Skip to content

fix the homebrew config #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

fix the homebrew config #36

wants to merge 17 commits into from

Conversation

rustiever
Copy link
Member

@rustiever rustiever commented Nov 22, 2022 •
edited
Loading

What does this PR change?

Does the PR depend on any other PRs or Issues? If yes, please list them.

  • no

Checklist

I confirm, that I have...

  • Read and followed the contributing guide in CONTRIBUTING.md
  • Added tests for this PR
  • Formatted the code using go fmt (if applicable)
  • Updated documentation on the Paralus docs site (if applicable)
  • Updated CHANGELOG.md

@rustiever rustiever changed the title Update release.yaml fix the homebrew config Nov 25, 2022
rustiever
rustiever commented Nov 25, 2022
View reviewed changes
.github/workflows/release.yaml
args: release --rm-dist
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
TOKEN: ${{ secrets.HOMEBREW_TAP_TOKEN }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to have token with repo level access @niravparikh05

akshay196
akshay196 reviewed Nov 28, 2022
View reviewed changes
@rustiever rustiever requested a review from akshay196 November 28, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niravparikh05 niravparikh05 Awaiting requested review from niravparikh05 niravparikh05 is a code owner

@akshay196 akshay196 Awaiting requested review from akshay196 akshay196 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rustiever @akshay196