Increase the MSRV to 1.53.0 #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionut-arm
approved these changes
Sep 28, 2021
| @@ -1,6 +1,5 @@ | |||
| [advisories] | |||
| ignore = ["RUSTSEC-2021-0073", # We do not use `prost_types::Timestamp` anywhere in our code. | |||
| "RUSTSEC-2020-0036"] # We don't have control over the exact dependencies of `protoc-grpcio`; See https://github.com/mtp401/protoc-grpcio/issues/36 | |||
| ignore = [] | |||
Comment on lines
+255
to
+257
| rustup toolchain install 1.53.0 | ||
| # The "jwt-svid-authenticator" can not be compiled on 1.53.0 | ||
| RUST_BACKTRACE=1 cargo +1.53.0 check --release --features=all-providers,direct-authenticator,unix-peer-credentials-authenticator |
|
Ahh, fuzz checks still failing, I think a |
hug-dev
force-pushed
the
lift-msrv-req
branch
from
63318b3 to
69d5238
Compare
|
I think it's because it's using the client before the PR we made today that fixes the issue there |
Also upgrades the prost and spiffe version to remove cargo audit vulnerabilities. Removes the ignored ones. Un-comment the CI checks that were commented before. Signed-off-by: Hugues de Valon <[email protected]>
hug-dev
force-pushed
the
lift-msrv-req
branch
from
69d5238 to
e5e6225
Compare
anta5010
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also upgrades the prost and spiffe version to remove cargo audit
vulnerabilities. Removes the ignored ones.
Un-comment the CI checks that were commented before.
Fix #514