Skip to content

Update instraction after installation path changes #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2020

Conversation

hug-dev
Copy link
Member

@hug-dev hug-dev commented Sep 24, 2020

See parallaxsecond/parsec#250 for details. Very early version now just for early feedback.

@hug-dev hug-dev added the invalid This doesn't seem right label Sep 24, 2020
@hug-dev hug-dev self-assigned this Sep 24, 2020
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♂️ thanks!

@hug-dev hug-dev marked this pull request as ready for review September 25, 2020 16:21
Signed-off-by: Hugues de Valon <[email protected]>
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments below, but I'm ok with the changes.

I'm curious about /etc/parsec having 700 permissions - all the /etc subdirectories on my WSL have at least read or execute for everyone else 😬


Create the following Parsec directories, with good permissions.

`/var/lib/parsec` for storing persistent data like the `mappings` folder. The service will run from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if this is a bit late - would you mind adding bulletpoints to this list? Something like:

  • /var/lib/parsec for storing persistent data like the mappings folder. The service will run from
    here
sudo mkdir /var/lib/parsec
sudo chown parsec /var/lib/parsec
sudo chmod 700 /var/lib/parsec

It reads a bit weirdly if you forget this is supposed to be a list

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good point! Will change.


From another terminal, it is now possible to execute the [end-to-end tests](tests#end-to-end-tests)
on Parsec!

```````
cd e2e_tests
cargo test normal_tests
cargo test --features mbed-crypto-provider normal_tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers 😅

@hug-dev
Copy link
Member Author

hug-dev commented Sep 28, 2020

I'm curious about /etc/parsec having 700 permissions - all the /etc subdirectories on my WSL have at least read or execute for everyone else 😬

That's true it's similar on my Fedora system. I applied the principle of least privilege, as in I don't think users other than parsec need to know what is inside that file (especially if you have confidential information contained in the configuration file name itself). But if it's not Unix-idiomatic I am happt to change, now or in the future.

@ionut-arm
Copy link
Member

I'm curious about /etc/parsec having 700 permissions - all the /etc subdirectories on my WSL have at least read or execute for everyone else 😬

That's true it's similar on my Fedora system. I applied the principle of least privilege, as in I don't think users other than parsec need to know what is inside that file (especially if you have confidential information contained in the configuration file name itself). But if it's not Unix-idiomatic I am happt to change, now or in the future.

I'd rather be secure than idiomatic, especially since config.toml will contain some pretty sensitive stuff. If someone thinks we're doing things wrong, we can reconsider it

@hug-dev hug-dev merged commit d01a93d into parallaxsecond:master Oct 2, 2020
@hug-dev hug-dev deleted the new-instructions branch October 2, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants