Skip to content

feat: eth_fillTransaction #19246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

feat: eth_fillTransaction #19246

wants to merge 11 commits into from

Conversation

@jxom
Copy link
Member

@jxom jxom commented Oct 23, 2025 •
edited
Loading

Proposes an implementation for ethereum/execution-apis#512.

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Oct 23, 2025
@jxom jxom marked this pull request as draft October 23, 2025 04:06
@jxom jxom marked this pull request as ready for review October 23, 2025 04:43
@jxom jxom requested a review from fgimenez as a code owner October 23, 2025 04:43
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 23, 2025

CodSpeed Performance Report

Merging #19246 will improve performances by 11.47%

Comparing jxom:jxom/eth-fill-transaction (1ecb642) with main (f8845c6)

Summary

⚡ 1 improvement
✅ 76 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ hash builder[init size 10000 | update size 100 | num updates 3] 28.1 ms 25.2 ms +11.47%

mattsse
mattsse reviewed Oct 24, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superseded by #19199

@mattsse mattsse closed this Oct 24, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Reth Tracker Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse left review comments

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@RomanHodulak RomanHodulak Awaiting requested review from RomanHodulak RomanHodulak is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Reth Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jxom @mattsse