chore(engine): remove unused local Rayon pool from WorkloadExecutor #18859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashass1315
requested review from
Rjected,
mattsse and
rkrasiuk
as code owners
sashass1315
requested review from
fgimenez,
mediocregopher and
yongkangc
as code owners
|
@shekhirin @mattsse what was the intention here? did we mean to use this rayon pool for payload validation and then never did? Or this is just some cleanup that didn't get completed? |
mattsse
reviewed
Oct 16, 2025
There was a problem hiding this comment.
ty, I cherry picked some doc changes into #19065
@mediocregopher we previously used this to spawn tx execution I believe but these can also do a bunch of io so we moved away from rayon here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the per-instance Rayon thread pool from WorkloadExecutor and delete unused methods with_num_cpu_threads(...) and rayon_pool(). The local pool was never referenced; parallelism in the payload processor uses Tokio spawn_blocking and the global Rayon pool configured at node launch. Keeping a private pool consumed resources without benefit, making it dead code.