feat(engine): add validate_payload and validate_block methods to EngineValidator trait #17429
+28
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
added
C-enhancement
mattsse
reviewed
Jul 15, 2025
mattsse
reviewed
Jul 15, 2025
fgimenez
force-pushed
the
fgimenez/extend-payload-validator
branch
from
48b5476 to
d24e849
Compare
mattsse
reviewed
Jul 16, 2025
crates/engine/primitives/src/lib.rs
Outdated
| @@ -106,7 +130,7 @@ pub trait EngineTypes: | |||
|
|
|||
| /// Type that validates an [`ExecutionPayload`]. | |||
| #[auto_impl::auto_impl(&, Arc)] | |||
| pub trait PayloadValidator: Send + Sync + Unpin + 'static { | |||
| pub trait PayloadValidator<State = ()>: Send + Sync + Unpin + 'static { | |||
There was a problem hiding this comment.
we likely don't need this generic if we make TreeCtx<'_, Self::Block>
There was a problem hiding this comment.
i believe it would be easier if TreeCtx can hold a full state instance, so that we can call the new methods like validate_payload(payload, TreeCtx { state: &self.state}) if we make TreeCtx generic over block this would be more difficult, or am i missing something?
There was a problem hiding this comment.
let#s figure this out later
There was a problem hiding this comment.
the trait is now generic over N: NodePrimitives
fgimenez
force-pushed
the
fgimenez/extend-payload-validator
branch
from
d24e849 to
9ffce5b
Compare
fgimenez
force-pushed
the
fgimenez/extend-payload-validator
branch
from
9ffce5b to
801520e
Compare
fgimenez
force-pushed
the
fgimenez/extend-payload-validator
branch
from
801520e to
8c8c463
Compare
fgimenez
requested review from
onbjerg,
gakonst,
DaniPopes,
joshieDo and
RomanHodulak
as code owners
fgimenez
changed the base branch from
main
to
fgimenez/validation-engine-primitives
fgimenez
force-pushed
the
fgimenez/validation-engine-primitives
branch
from
e8d32ea to
cfb66da
Compare
fgimenez
force-pushed
the
fgimenez/extend-payload-validator
branch
from
8c8c463 to
22354ff
Compare
fgimenez
force-pushed
the
fgimenez/validation-engine-primitives
branch
from
cfb66da to
a18e6be
Compare
fgimenez
force-pushed
the
fgimenez/extend-payload-validator
branch
from
22354ff to
92dd6c1
Compare
fgimenez
changed the title
klkvr
reviewed
Jul 23, 2025
Comment on lines
976
to
979
| pub trait EngineValidator< | ||
| Types: PayloadTypes, | ||
| N: NodePrimitives = reth_ethereum_primitives::EthPrimitives, | ||
| >: PayloadValidator<ExecutionData = Types::ExecutionData> |
There was a problem hiding this comment.
NodePrimitives are already available as Types::BuiltPayload::Primitives
…neValidator trait
fgimenez
force-pushed
the
fgimenez/extend-payload-validator
branch
from
e1481b7 to
c139158
Compare
mattsse
approved these changes
Jul 23, 2025
klkvr
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #17413
Adds new validation methods to the
EngineValidatortrait as a first step towards repurposing it for more flexible payload and block validation.validate_payloadandvalidate_blockmethods with default implementations to maintain backward compatibility