fix(slackbot): drop the 'Thinking...' assistant.threads.setStatus pill#99
Closed
arjunblj wants to merge 1 commit into
Closed
fix(slackbot): drop the 'Thinking...' assistant.threads.setStatus pill#99arjunblj wants to merge 1 commit into
arjunblj wants to merge 1 commit into
Conversation
The static "Thinking..." pill stayed lit on the open-agent-session path until Slack's stream UI took over, which was both redundant with the streaming indicator and triggered an extra assistant.threads.setStatus call on every channel - including ones the API rejects with user_not_found. Just drop the setStatus call on open(); statusCleared starts true so the clear-status paths also short-circuit. The setStatus method stays in place so future status flows can re-enable it deliberately.
dennisonbertram
pushed a commit
to dennisonbertram/centaur
that referenced
this pull request
May 27, 2026
Add a merged-PR fallback trigger for deploys and skip duplicate push jobs from web-flow merges so deploy remains reliable even when GitHub omits push-triggered Actions suites for squash merges. Co-authored-by: arjunblj <arjunblj@users.noreply.github.com>
Member
|
We've merged the Rust rewrite in #344, meaning the old API and Slackbot services are deprecated. As such we're closing this PR - if you think this is a mistake, please reopen the PR and ping me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assistant.threads.setStatus(Thinking...)on agent-session open; the streaming UI already signals work.statusCleared: trueso the clear-status paths short-circuit.Test plan
bun --cwd services/slackbot test src/slack/agent-session.test.ts