fix(proxy): allow Datadog API-key auth headers#476
Open
cjustice wants to merge 1 commit into
Open
Conversation
Datadog's REST API authenticates with the DD-API-KEY (org API key) and DD-APPLICATION-KEY (application key) request headers. iron-proxy's header_allowlist strips any header not on the list before egress, so a Datadog tool's requests reach the API unauthenticated and get a 403. Add both headers to the allowlist (both copies of the iron-proxy base config) plus a proxy-config regression test, mirroring the existing per-tool header additions (x-as-user-email, mcp-*, project-access-token, x-amz-*). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DD-API-KEYandDD-APPLICATION-KEYrequest headers (added to both copies of the iron-proxy base config)Why
Datadog's REST API authenticates with two headers —
DD-API-KEY(org API key) andDD-APPLICATION-KEY(application key); it does not acceptAuthorization: Bearer <api_key>for static-key auth. Because neitherdd--prefixed header is on iron-proxy'sheader_allowlist(and they don't match the^x-…(api-key|token|auth|key)$catch-all), the proxy strips them before egress, so a Datadog tool's requests reachapi.datadoghq.comunauthenticated and get a 403. This mirrors the existing per-tool header additions (x-as-user-email,mcp-*,project-access-token,x-amz-*).Test
uv run --project services/api pytest services/api/tests/test_proxy_config.py