fix: post Slack sends to other channels instead of capturing into active thread#447
Closed
mslipper wants to merge 1 commit into
Closed
fix: post Slack sends to other channels instead of capturing into active thread#447mslipper wants to merge 1 commit into
mslipper wants to merge 1 commit into
Conversation
Member
|
We've merged the Rust rewrite in #344, meaning the old API and Slackbot services are deprecated. As such we're closing this PR - if you think this is a mistake, please reopen the PR and ping me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live-delivery capture in
_capture_live_slack_sendwas swallowingslack.send_messagecalls that targeted a different channel and folding them into the active thread reply. The guard for "is this bound for the active thread?" only bailed when the channel was a Slack ID that differed, so a different channel referenced by name (or withthread_tsomitted) was wrongly captured — the agent would report it had posted nothing to the requested channel.This inverts the logic to opt-in: capture only when the request is unambiguously bound for the active thread (empty/matching channel and empty/matching thread). Since the active channel from the thread_key is always a Slack ID, a channel name now correctly fails the match and posts normally. Adds
TestCaptureLiveSlackSendcovering the active-thread, different-ID, different-name, and different-thread cases.