Fix Slack live delivery status and empty fallback#408
Open
Geeknerd1337 wants to merge 1 commit into
Open
Conversation
Author
|
This fixes #358 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Problem
Long-running Slack sessions could look dead even while Centaur was still running.
The tool/task stream continued internally, but Slack's assistant status was cleared after the first visible streamed output. For long executions, that meant the thread could stop showing an active "Thinking..." state even though tool calls and chain-of-thought style progress were still being processed.
We also found a related blank-delivery edge case. If Slack live delivery was enabled but the model produced zero visible answer characters, the API treated live delivery as already covering the result. That suppressed the durable final-delivery fallback, so a no-output execution could complete without posting a useful fallback message.
Fix
Thinking...status every 30 seconds while the session is active.done()runs.Relevant Issues Fixed
Thinking...disappears too soon.Test Plan
bun test src/*.test.ts src/**/*.test.tsinservices/slackbotbun run check:typesinservices/slackbot/Users/fin-sa/centaur/services/api/.venv/bin/python -m pytest tests/test_agent_control_plane.py -k "slackbot_streamed_answer_chars or live_answer"inservices/api/Users/fin-sa/centaur/services/api/.venv/bin/python -m ruff check api/runtime_control.py tests/test_agent_control_plane.pyinservices/api