Skip to content

fix(ui): show success toast when saving agent configuration #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bluzername wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −0
Open

fix(ui): show success toast when saving agent configuration #1931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/src/pages/AgentDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1447,6 +1447,7 @@ function ConfigurationTab({
queryClient.invalidateQueries({ queryKey: queryKeys.agents.detail(agent.urlKey) });
queryClient.invalidateQueries({ queryKey: queryKeys.agents.configRevisions(agent.id) });
queryClient.invalidateQueries({ queryKey: queryKeys.agents.list(agent.companyId) });
pushToast({ title: "Agent saved", tone: "success" });
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 PR description missing "thinking path" and screenshots

Per CONTRIBUTING.md, a good PR message should include:

  1. A "thinking path" that explains the reasoning from the top of the project down to the specific fix (see examples in CONTRIBUTING.md).
  2. Before/after screenshots for any visible UI change — this PR introduces a new success toast, which is a visual change.

The current description explains the problem and the fix well, but it doesn't follow the structured thinking-path format, and no screenshots are included to show what the new success toast looks like.

Could you update the PR description to add a thinking path and include before/after screenshots of the success toast?

Context Used: CONTRIBUTING.md has a guide for a good PR message ... (source)

Prompt To Fix With AI 
This is a comment left during a code review.
Path: ui/src/pages/AgentDetail.tsx
Line: 1450

Comment:
**PR description missing "thinking path" and screenshots**

Per `CONTRIBUTING.md`, a good PR message should include:
1. A **"thinking path"** that explains the reasoning from the top of the project down to the specific fix (see examples in `CONTRIBUTING.md`).
2. **Before/after screenshots** for any visible UI change — this PR introduces a new success toast, which is a visual change.

The current description explains the problem and the fix well, but it doesn't follow the structured thinking-path format, and no screenshots are included to show what the new success toast looks like.

Could you update the PR description to add a thinking path and include before/after screenshots of the success toast?

**Context Used:** CONTRIBUTING.md has a guide for a good PR message ... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

},
onError: (err) => {
setAwaitingRefreshAfterSave(false);
Expand Down
Loading