Skip to content

fix(a11y): add aria-pressed to date preset and day-of-week toggle buttons #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bluzername wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

fix(a11y): add aria-pressed to date preset and day-of-week toggle buttons #1913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/src/components/ScheduleEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ export function ScheduleEditor({
variant={dayOfWeek === d.value ? "default" : "outline"}
size="sm"
className="h-7 px-2 text-xs"
aria-pressed={dayOfWeek === d.value}
onClick={() => {
setDayOfWeek(d.value);
emitChange(preset, hour, minute, d.value, dayOfMonth, customCron);
Expand Down
1 change: 1 addition & 0 deletions ui/src/pages/Costs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,7 @@ export function Costs() {
variant={preset === key ? "secondary" : "ghost"}
size="sm"
onClick={() => setPreset(key)}
aria-pressed={preset === key}
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 PR description is missing a thinking path and risks section

Per CONTRIBUTING.md, PR descriptions should include a thinking path — a top-down chain of reasoning from the project level down to the specific change — as well as explicit details on risks (even if there are none). For example:

  • Paperclip orchestrates AI agents for zero-human companies
  • Humans and assistive-technology users interact with the web UI
  • Screen-reader users rely on ARIA attributes to understand widget state
  • Toggle button groups in the UI were missing aria-pressed, so their active state was invisible to screen readers
  • This PR adds aria-pressed to the date-preset and day-of-week toggle groups
  • Risks: None — ARIA attributes are purely additive and have no effect on visual rendering or logic

Please add both sections to the PR description so reviewers have the full context the guide asks for.

Context Used: CONTRIBUTING.md has a guide for a good PR message ... (source)

Prompt To Fix With AI 
This is a comment left during a code review.
Path: ui/src/pages/Costs.tsx
Line: 557

Comment:
**PR description is missing a thinking path and risks section**

Per CONTRIBUTING.md, PR descriptions should include a **thinking path** — a top-down chain of reasoning from the project level down to the specific change — as well as explicit details on risks (even if there are none). For example:

> - Paperclip orchestrates AI agents for zero-human companies
> - Humans and assistive-technology users interact with the web UI
> - Screen-reader users rely on ARIA attributes to understand widget state
> - Toggle button groups in the UI were missing `aria-pressed`, so their active state was invisible to screen readers
> - This PR adds `aria-pressed` to the date-preset and day-of-week toggle groups
> - **Risks:** None — ARIA attributes are purely additive and have no effect on visual rendering or logic

Please add both sections to the PR description so reviewers have the full context the guide asks for.

**Context Used:** CONTRIBUTING.md has a guide for a good PR message ... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

>
{PRESET_LABELS[key]}
</Button>
Expand Down
Loading