Skip to content

fix(routines): add missing feedback after trigger create/save #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LArtistaDMorte wants to merge 1 commit into
base: paperclip-routines
Choose a base branch
from
+4 −0
Open

fix(routines): add missing feedback after trigger create/save #1908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ui/src/pages/RoutineDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,10 @@ export function RoutineDetail() {
webhookUrl: result.secretMaterial.webhookUrl,
webhookSecret: result.secretMaterial.webhookSecret,
});
} else {
pushToast({ title: "Trigger added", tone: "success" });
}
setNewTrigger({ kind: "schedule", cronExpression: "0 10 * * *", signingMode: "bearer", replayWindowSec: "300" });
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Form also resets for webhook triggers

setNewTrigger(...) is now unconditionally called for both webhook and schedule trigger creation. For webhook triggers this means the form resets even though the user is shown the secretMessage banner (which is fine UX), but it is a behaviour change versus the pre-PR code. It's worth confirming this is intentional: should a webhook creator be able to create a second webhook immediately after without re-selecting the "webhook" kind from the dropdown? Currently the form snaps back to kind: "schedule" for both paths.

If the reset for webhook triggers is not desired, moving the call inside the else block is the minimal fix:

Suggested change
setNewTrigger({ kind: "schedule", cronExpression: "0 10 * * *", signingMode: "bearer", replayWindowSec: "300" });
setNewTrigger({ kind: "schedule", cronExpression: "0 10 * * *", signingMode: "bearer", replayWindowSec: "300" });

(no change needed — just flagging so it's a conscious decision rather than an accidental side-effect)

Prompt To Fix With AI 
This is a comment left during a code review.
Path: ui/src/pages/RoutineDetail.tsx
Line: 482

Comment:
**Form also resets for webhook triggers**

`setNewTrigger(...)` is now unconditionally called for both webhook and schedule trigger creation. For webhook triggers this means the form resets even though the user is shown the `secretMessage` banner (which is fine UX), but it is a behaviour change versus the pre-PR code. It's worth confirming this is intentional: should a webhook creator be able to create a second webhook immediately after without re-selecting the "webhook" kind from the dropdown? Currently the form snaps back to `kind: "schedule"` for both paths.

If the reset for webhook triggers is not desired, moving the call inside the `else` block is the minimal fix:

```suggestion
      setNewTrigger({ kind: "schedule", cronExpression: "0 10 * * *", signingMode: "bearer", replayWindowSec: "300" });
```
(no change needed — just flagging so it's a conscious decision rather than an accidental side-effect)

How can I resolve this? If you propose a fix, please make it concise.

await Promise.all([
queryClient.invalidateQueries({ queryKey: queryKeys.routines.detail(routineId!) }),
queryClient.invalidateQueries({ queryKey: queryKeys.routines.list(selectedCompanyId!) }),
Expand All @@ -495,6 +498,7 @@ export function RoutineDetail() {
const updateTrigger = useMutation({
mutationFn: ({ id, patch }: { id: string; patch: Record<string, unknown> }) => routinesApi.updateTrigger(id, patch),
onSuccess: async () => {
pushToast({ title: "Trigger saved", tone: "success" });
await Promise.all([
queryClient.invalidateQueries({ queryKey: queryKeys.routines.detail(routineId!) }),
queryClient.invalidateQueries({ queryKey: queryKeys.routines.list(selectedCompanyId!) }),
Expand Down