Don't use nodegit-papandreou. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papandreou
added a commit
that referenced
this pull request
Sep 8, 2014
Don't use nodegit-papandreou.
|
Thanks! I had a completely identical, unpushed commit lying around. Well, identical except you fixed a missing newline at EOF that I didn't :) |
|
Released gitfakefs 0.3.0 and fsplusgit 0.2.0, then updated slint to fsplusgit 0.2.0 on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slint doesn't build, because nodegit-papandreou can't properly build libgit2 properly.
Stock nodegit can (and seem to incorporate all requests from papandreou), so I've tried using that.
It does, however, still fail a single unit-test (I strongly suspect git/libgit knowledge will make it easier to debug).