Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where pants run only working when package.json at root #21849

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

riisi
Copy link
Contributor

@riisi riisi commented Jan 17, 2025

Fixes #21793

Note this now aligns with how the node build script is run as part of pants package goal here. Separately, I don't know if that logic can be consolidated.

@riisi riisi added the category:bugfix Bug fixes for released features label Jan 17, 2025
@riisi riisi requested a review from tobni January 17, 2025 07:11
Copy link
Contributor

@tobni tobni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cburroughs cburroughs merged commit 9e4ff05 into pantsbuild:main Jan 22, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pants run for nodejs only works if package.json in root directory
3 participants