Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor][CMSP-777] bump domain upper limit #35

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

jazzsequence
Copy link
Contributor

@jazzsequence jazzsequence commented Jun 3, 2024

This PR updates the max domains allowed from 25 to 75.
Updates the tests so the 29 domain test should now pass and adds a new test for a 79 domain test that should fail.
Updated the test site names to something other than site1, site2, etc because fantasy creatures are more fun.

@jazzsequence jazzsequence marked this pull request as ready for review June 3, 2024 21:10
@jazzsequence jazzsequence requested a review from a team as a code owner June 3, 2024 21:10
@jazzsequence jazzsequence requested a review from pwtyler June 3, 2024 21:10
@pwtyler pwtyler changed the title [CMSP-777] bump domain upper limit [minor][CMSP-777] bump domain upper limit Jun 3, 2024
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏰🐲🎲 LGTM

@pwtyler pwtyler merged commit 8d4069b into main Jun 10, 2024
7 checks passed
@pwtyler pwtyler deleted the cmsp-777-bump-domain-upper-limit branch June 10, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants