-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9354 tutorial move #9364
base: main
Are you sure you want to change the base?
9354 tutorial move #9364
Conversation
Hi from your friendly robot! 🤖 I've applied Prettier formatting to the following files in fa379f9:
The full diff is below. Please review the changes. Click to expanddiff --git a/src/components/omniSidebarNav/submenus/certification.js b/src/components/omniSidebarNav/submenus/certification.js
index daf8f4d2c..63f24b77f 100644
--- a/src/components/omniSidebarNav/submenus/certification.js
+++ b/src/components/omniSidebarNav/submenus/certification.js
@@ -81,7 +81,10 @@ const CertificationItems = () => {
getGuideDirectory('guides/wordpress-git', 'WordPress and Git'),
getGuideDirectory('guides/pagerduty', 'Incident Management'),
getGuideDirectory('guides/accessibility', 'Web Accesibility'),
- simpleLink('/tutorials/drupal-site-creation-and-workflow-commandline', 'All CLI workflow with Terminus and Drupal'),
+ simpleLink(
+ '/tutorials/drupal-site-creation-and-workflow-commandline',
+ 'All CLI workflow with Terminus and Drupal',
+ ),
simpleLink('/pivotal-tracker', 'Pivotal Tracker'),
simpleLink('/pingdom-uptime-check', 'Pingdom Uptime Check'),
|
@stevector Is this a new standard we want to impose across the entire codebase in the longterm? Where we 1) relocate .md files to a new subdir based on the respective submenu AND 2) update URLs to include the respective submenu? e.g., moving There are contributor experience gains I think to this move, but since we have an "edit this page" button on every doc I'm not sure anyone outside of our team would notice a difference Are there UX gains unlocked by adopting this standard? like would it get us closer to a unified sidebar experience? If not, I think my preference is to leave submenus out of our permalink structures and ignore submenus in the directory structure, for simpler URLs but also because it would be a lot of effort and time required to do this with not a lot of payoff What I had in mind for these follow up todos, where one page of a multipage guide needs to be relocated to a different submenu, was simply relocating the file from Since that's the existing standard for like 90% of the codebase |
@rachelwhitton I'd be fine with putting this doc at |
@stevector can you review latest commit? I revised this based on discussion above |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9364-documentation.appa.pantheon.site |
Closes #9354
@rachelwhitton, can you review? I might be breaking your preference for short URL paths here.