[BUGS-7678] define PANTHEON_HOSTNAME constant #381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwtyler
changed the title
pwtyler
reviewed
Apr 29, 2024
9 tasks
pwtyler
approved these changes
Apr 29, 2024
jazzsequence
force-pushed
the
cmsp-7678-add-pantheon_hostname
branch
from
f90bf2b to
8cff967
Compare
|
Somehow my squash included unrelated stuff (possibly because of the merge commit). I'm going to create a new branch with a single commit and close this. |
|
closed in favor of #382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
PANTHEON_HOSTNAMEconstant which defaults to$_SERVER['HTTP_HOST']if it exists.When used to define
DOMAIN_CURRENT_SITEon WordPress multisites (e.g.define( 'DOMAIN_CURRENT_SITE', PANTHEON_HOSTNAME )), this solves the "undefined index HTTP_HOST" error that shows up in PHP error logs.