Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use errors.Is and errors.Join for customized errors #640

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

panjf2000
Copy link
Owner

No description provided.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.34%. Comparing base (29dca4f) to head (0ad8b95).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
engine_unix.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #640   +/-   ##
=======================================
  Coverage   80.34%   80.34%           
=======================================
  Files          21       21           
  Lines        2096     2096           
=======================================
  Hits         1684     1684           
  Misses        285      285           
  Partials      127      127           
Flag Coverage Δ
unittests 80.34% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 changed the title chore: use errors.Join of go1.20 on Windows chore: use errors.Is and errors.Join for customized errors Sep 26, 2024
@panjf2000 panjf2000 added enhancement New feature or request optimization Some small optimizations labels Sep 26, 2024
@panjf2000 panjf2000 merged commit e520399 into dev Sep 26, 2024
34 of 35 checks passed
@panjf2000 panjf2000 deleted the errors-join-windows branch September 26, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chores enhancement New feature or request optimization Some small optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant