Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt: close file descriptor after OnClose() for UDP along with code improvement #624

Merged
merged 2 commits into from
Jul 3, 2024
Merged

opt: close file descriptor after OnClose() for UDP along with code improvement #624

merged 2 commits into from
Jul 3, 2024

Conversation

panjf2000
Copy link
Owner

@panjf2000 panjf2000 commented Jul 3, 2024 •
edited
Loading

Updates #621

Follows up #622

This PR also fixes the potential UDP socket leaks for Windows client.

@github-actions github-actions bot added the enhancement New feature or request label Jul 3, 2024
@panjf2000 panjf2000 added bug Something isn't working optimization Some small optimizations labels Jul 3, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.74%. Comparing base (1ed4d08) to head (3f9e09b).

Files Patch % Lines
eventloop_windows.go 75.00% 1 Missing and 1 partial ⚠️
eventloop_unix.go 94.11% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #624      +/-   ##
==========================================
- Coverage   80.81%   80.74%   -0.07%     
==========================================
  Files          21       21              
  Lines        2116     2098      -18     
==========================================
- Hits         1710     1694      -16     
+ Misses        276      274       -2     
  Partials      130      130
Flag Coverage Δ
unittests 80.74% <88.46%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit 70472bf into dev Jul 3, 2024
35 of 37 checks passed
@panjf2000 panjf2000 deleted the close-opt branch July 3, 2024 12:36
panjf2000 added a commit that referenced this pull request Jul 3, 2024
@panjf2000
opt: prevent server-side UDP sockets in eventloop.close() on Windows
42cc9a8 
Follows up #624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request optimization Some small optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@panjf2000