Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: close file descriptor after OnClose() #622

Merged
merged 1 commit into from
Jul 3, 2024

opt: close file descriptor after OnClose()

b7aef26
Select commit
Loading
Failed to load commit list.
Merged

opt: close file descriptor after OnClose() #622

opt: close file descriptor after OnClose()
b7aef26
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 3, 2024 in 0s

80.76% (-0.13%) compared to 8a80aaf

View this Pull Request on Codecov

80.76% (-0.13%) compared to 8a80aaf

Details

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 80.76%. Comparing base (8a80aaf) to head (b7aef26).

Files Patch % Lines
eventloop_unix.go 28.57% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #622      +/-   ##
==========================================
- Coverage   80.89%   80.76%   -0.13%     
==========================================
  Files          21       21              
  Lines        2109     2116       +7     
==========================================
+ Hits         1706     1709       +3     
- Misses        273      276       +3     
- Partials      130      131       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.