-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction Tutorial #281
Conversation
@rwegener2 and I had a great synchronous discussion of this PR. This is definitely pointing us in the right direction for OSM. Just to record next steps:
Rachel and I are going to check in again on video about these items on Thursday. |
@rabernat In the "Recipe Tutorials" section you were able to get the |
Can you clarify what you mean by "show up"? The sphinx site is configured with the myst_nb extension pangeo-forge-recipes/docs/conf.py Lines 9 to 10 in ce9d8b9
This allows us to treat notebooks as valid documentation pages, e.g. pangeo-forge-recipes/docs/tutorials/index.md Lines 9 to 17 in ce9d8b9
These references are to ipynb files. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
DoneThe latest push adds improvements from @cisaacstern:
Saved for laterIdeas that I like but are enough of a lift that I would like to save them for a separate PR:
Ready for reviewI think this is set so I'm requesting review! If I forget someone or add an unnecessary someone of course just update the reviewers. |
@rwegener2 this is great progress! I had a quick skim and am going to give this a more thorough review later today. One general comment I have is that I really think we should not use If helpful to flesh this idea out, I could push a commit to this branch which rewrites the tutorial along these lines. If we don't like it, we could revert. How does that sound? |
@rabernat That sounds great. I think it's important that the way of generating a file pattern is the easiest way possible, so if you think that way is without |
@rwegener2 - have a look at what I just pushed and let me know if you think it is clear. I think it is actually more understandable this way, but of course I wrote the code so I am biased! 🙃 |
Thanks @rabernat. I really like the tone and clarity you have while writing. My thoughts on the direct use of FilePattern: I do think that is a more conceptually challenging flow, but on the flip side it starts building a foundation for how File Pattern objects work that will be useful to a user that continues to use the system. If I were being totally honest, I would personally stick with So, moving forward with the direct use of FilePattern object: I like the text @rabernat wrote. To keep the amount of material more even between tutorials I want to move making the recipe object (basically just the line Thanks for all the review, everyone. I'm happy we are dedicating time to this. |
Thanks for your flexibility here Rachel. I do feel strongly that this is the best way to build a foundation of understanding. But I note your concerns about the extra complexity to digest. A deliberate design decision in Pangeo Forge has been to move a lot of the complexity in the FilePattern layer. That way the Recipe itself can be pretty simple.
👍 from me Do you want to merge this as is and keep working via another PR? |
In the spirit of iteration I think we can merge. Just give me a 👍🏻 if that is my job. If someone else does it they should feel free to squash merge because my commits got pretty messy. |
🎉 yay! |
What has been built?
This PR address the first part of Issue #280. It creates Part 1 of an updated Introduction Tutorial sequence, which focuses on Defining a recipe.
How was it done?
introduction_tutorial
with the 1st part of the new tutorial and anindex.md
for that folder (2 more parts to come)docs/index.md
with the new structureintro_tutorial.md
How can it be tested?
Clicking "Details" for the docs test that gets run by CI.
Notes
As a reminder from the intro issue, my goal with the introduction tutorial is for the user to be able to understand as little information as is necessary to perform a meaningful piece of work with the tool.
There are a few decisions I made while doing this that I wanted to flag for feedback:
pattern_from_file_sequence
structure instead of theFilePattern
structure for the reason that I think it is conceptually and technically easier.One other thing that also occurred to me while writing this is that
FilePattern
andXarrayZarrRecipe
objects for me feel challenging to inspect. I'll start a separate issue on that to follow up and ask questions.I look forward to feedback and reactions!