Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add static openapi docs to sphinx site #28

Closed
wants to merge 1 commit into from
Closed

Add static openapi docs to sphinx site #28

wants to merge 1 commit into from

Conversation

rabernat
Copy link
Contributor

@rabernat rabernat commented Jan 18, 2022

closes #9

The only thing I don't like about this is how the title shows up twice 🧐

image

@rabernat
Copy link
Contributor Author

Due to sphinx-contrib/openapi#107, it looks like sphinxcontrib.openapi does not correctly handle openapi 3.0.0 specs. We are having the same problem as that issue: the docs don't show request or response json parameters.

Copy link
Member

@cisaacstern cisaacstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And presumably the double title issue is unrelated to this PR, so IMO we can merge this.

sphinxcontrib-openapi is cool! (And will be even better with OpenAPI 3 support.)

@@ -4,4 +4,6 @@ myst-parser==0.13.6
myst-nb==0.12.3
sphinx-copybutton==0.3.1
sphinx-autodoc-typehints
sphinxcontrib-openapi
uvicorn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why does this require uvicorn?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Originally I thought you had to run the server, but I found a way to avoid that.

@cisaacstern
Copy link
Member

Following #9 (comment), going to close this, because it is superseded by #45. We can revisit it if we ever decide to go back to Sphinx.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add auto-generated API docs to the sphinx website
2 participants