Use PyWeakref_GetRef and critical section in BlockValuesRefs #60540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lysnikolaou
commented
Dec 11, 2024
lysnikolaou
commented
- Related to ENH: Python 3.13 free-threading support #59057
- All code checks passed.
lysnikolaou
force-pushed
the
lock-block-values-refs
branch
from
4e28feb to
e21c3c9
Compare
WillAyd
reviewed
Dec 11, 2024
| @@ -927,8 +935,9 @@ cdef class BlockValuesRefs: | |||
| blk : Block | |||
| The block that the new references should point to. | |||
| """ | |||
| self._clear_dead_references() | |||
| self.referenced_blocks.append(PyWeakref_NewRef(blk, None)) | |||
| with cython.critical_section(self): | |||
There was a problem hiding this comment.
For the uninformed what does the critical section do? Grab hold of the GIL or some other global mutex?
There was a problem hiding this comment.
A critical section is a per-object lock (here we're locking self, so an instance of BlockValuesRefs) that has a deadlock avoidance mechanism on top of it. More info on the Python docs.
rhshadrach
added
Enhancement
Build
|
Perf impact? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.