-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix PR02 errors in Timedelta attributes (min, max, resolution) d… #60486
Open
brownl83
wants to merge
30
commits into
pandas-dev:main
Choose a base branch
from
brownl83:fix-timedelta-docstrings-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DOC: Fix PR02 errors in Timedelta attributes (min, max, resolution) d… #60486
brownl83
wants to merge
30
commits into
pandas-dev:main
from
brownl83:fix-timedelta-docstrings-cleanup
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks for your pr, looks like there's some issues
|
I will take any suggestions on how to deal with those unknown parameters, as I have exhausted all possible ideas. I am not sure that the min, max, and Resolution are good to be tagged with the "good first issue". |
Can the ignores be left in code_checks.sh and still have it update the documentation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #59698
Addresses:
pandas.Timedelta
Added the missing explanations (PRO2) for min, max, and resolution.
Removed from code_checks.sh
i "pandas.Timedelta.resolution PR02"
i "pandas.Timedelta.min PR02"
i "pandas.Timedelta.resolution PR02" \