-
-
Notifications
You must be signed in to change notification settings - Fork 140
Add calamine Excel reader #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR. Would like opinion of @twoertwein to determine if we should add tests for |
Also, CI is failing because a change was made in pyright 1.1.356, so you can lock down pyright to 1.1.354 in this PR in |
I'm not familiar with how python-calamine is packaged. Assuming its pypi package contains everything to test it, I don't see a reason not to make it a development dependency. If we have to install packages that are not on Pypi, I would be inclined to have tests inside a TYPE_CHECKING block instead. |
It is on pypi and conda-forge, so I think we'd be OK. I was concerned that it is built on top of rust, and I don't know if that means a whole lot of other stuff gets installed as a result. @davetapley Open to have you add tests to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you merge with upstream/main
- CI is failing because of that. And update the pyright version as indicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @davetapley
Since pandas-dev/pandas#54998
No existing tests covering
engine
, I can add if needed?