type args and kwargs as Any in frame.pyi #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Mar 18, 2025
Comment on lines
-1513
to
1540
| @overload | ||
| def mode( | ||
| self, | ||
| axis: Axis = ..., | ||
| skipna: _bool = ..., | ||
| numeric_only: _bool = ..., | ||
| *, | ||
| level: Level, | ||
| **kwargs, | ||
| ) -> Self: ... | ||
| @overload | ||
| def mode( | ||
| self, | ||
| axis: Axis = ..., | ||
| skipna: _bool = ..., | ||
| level: None = ..., | ||
| numeric_only: _bool = ..., | ||
| **kwargs, | ||
| dropna: _bool = ..., | ||
| ) -> Series: ... |
There was a problem hiding this comment.
skipna and level aren't valid arguments to DataFrame.mode https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.mode.html
these may have been taken from a really old pandas version?
There was a problem hiding this comment.
skipnaandlevelaren't valid arguments toDataFrame.modehttps://pandas.pydata.org/docs/reference/api/pandas.DataFrame.mode.htmlthese may have been taken from a really old pandas version?
the original stubs created by Microsoft were based on pandas 1.3 (or maybe earlier). So there is still a lot of stuff remaining from that version that never got cleaned up. Including updates to pandas beyond that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1168
These are all cases where
kwargs/argsjust exist for compatibility with numpyExceptions are:
query: typekwargsinDataFrame.queryaccording toDataFrame.eval#1173pct_change: typekwargsinpct_changeaccording to params inshift#1169to_clipboard: typekwargsinDataFrame.to_clipboardaccording toto_csv#1174assign: I'll open a separate PR for that one nowagg/transform: users can pass their own function so these can really beAnyCloses #xxxx (Replace xxxx with the Github issue number)
Tests added: Please use
assert_type()to assert the type of any return value