This repository was archived by the owner on Mar 16, 2021. It is now read-only.
fix: Copy clipboard on mobile devices - #221
Open
memoyil wants to merge 1 commit into
Open
Conversation
Author
|
Hi @ArtemKolichenkov, I had a problem with my git username and mail in other pr's commits. I decided to create a new pr with correct username and mail. I visited your comments and applied here. Please reviewe again. Thank you |
ArtemKolichenkov
approved these changes
Mar 13, 2021
ArtemKolichenkov
left a comment
ArtemKolichenkov
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for patching up the logic 馃憤
Trust Wallet might fix the issue soon, but I guess it is good to have this fallback to account for some other mobile wallets with DApp WebView browsers.
Contributor
|
Waiting to see if the TW team fix this before we merge a more hacky solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/pancakeswap/pancake-frontend/issues/648