fix: Crash when number of pools invalid #11140
Conversation
memoyil
requested review from
ChefMomota,
Chef-Yogi,
chefjackson,
ChefJerry,
thechefpenguin,
chef-eric and
chef-ryan
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
| @@ -235,7 +236,7 @@ export function useMultipleContractSingleData<TAbi extends Abi | readonly unknow | |||
| }: // FIXME: wagmiv2 | |||
| // MultipleSameDataCallParameters<TAbi, TFunctionName>): CallState<ContractFunctionResult<TAbi, TFunctionName>>[] { | |||
| MultipleSameDataCallParameters<TAbi, TFunctionName>): CallState<any>[] { | |||
| const { enabled, blocksPerFetch } = options ?? { enabled: true } | |||
There was a problem hiding this comment.
this is potential bug if options set without enabled param which causes enabled false/undefined by default which is unexpected
|
memoyil
force-pushed
the
feature/fix_crash_when_number_of_pools_invalid
branch
from
0ba841b to
705853f
Compare
memoyil
force-pushed
the
feature/fix_crash_when_number_of_pools_invalid
branch
from
705853f to
4792355
Compare
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
memoyil
force-pushed
the
feature/fix_crash_when_number_of_pools_invalid
branch
from
4518403 to
1ce3f7c
Compare
This reverts commit 98fa244.
PR-Codex overview
This PR focuses on improving the handling of the
enabledoption in various hooks related to contract calls, ensuring that calls are only made when appropriate conditions are met.Detailed summary
numberOfPoolstopoolLengthNumberfor clarity.poolLengthNumberto ensure it's a safe integer and non-negative.enabledoption inuseSingleContractMultipleDatato conditionally execute calls.enabledflag before making contract calls.