Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash in bridge input pasted non-numeric and add v1link translation #11132

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Jan 13, 2025


PR-Codex overview

This PR focuses on enhancing the CanonicalBridge component by adding support for a customizable v1LinkText prop, allowing dynamic text for the V1BridgeLink. It also introduces a new hook from @pancakeswap/hooks and improves input validation.

Detailed summary

  • Updated package.json to add @pancakeswap/hooks.
  • Modified V1BridgeLink to accept v1LinkText as a prop.
  • Passed translated text for the V1 bridge link from BridgePage.
  • Added useLastUpdated hook and input validation in CanonicalBridge.
  • Adjusted the rendering of V1BridgeLink to utilize the new prop.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 1:23pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 1:23pm
blog ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 1:23pm
bridge ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 1:23pm
games ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 1:23pm
gamification ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 1:23pm
uikit ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 1:23pm
ton ⬜️ Skipped (Inspect) Feb 17, 2025 1:23pm

Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: 99dea64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@memoyil memoyil changed the title fix: Bridge input pasted non-numeric in mobile fix: Crash in bridge input pasted non-numeric in mobile Jan 13, 2025
@memoyil memoyil marked this pull request as draft January 13, 2025 14:53
@memoyil memoyil force-pushed the feature/fix_bridge_input_paste_non_numeric_in_mobile branch from 904aaae to 7a1ba6a Compare January 13, 2025 17:37
@memoyil memoyil marked this pull request as ready for review January 13, 2025 17:38
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 13, 2025
@vercel vercel bot temporarily deployed to Preview – ton January 13, 2025 17:43 Inactive
@vercel vercel bot temporarily deployed to Preview – ton January 13, 2025 17:48 Inactive
@memoyil memoyil changed the title fix: Crash in bridge input pasted non-numeric in mobile fix: Crash in bridge input pasted non-numeric in mobile and add v1link translation Jan 13, 2025
@memoyil memoyil added the Sentry label Jan 13, 2025
@memoyil memoyil changed the title fix: Crash in bridge input pasted non-numeric in mobile and add v1link translation fix: Crash in bridge input pasted non-numeric and add v1link translation Jan 13, 2025
@vercel vercel bot temporarily deployed to Preview – ton January 13, 2025 18:24 Inactive
Copy link

socket-security bot commented Jan 14, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None +30 996 kB types
npm/@types/[email protected] None 0 6.45 kB types

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Jan 14, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@vercel vercel bot temporarily deployed to Preview – ton January 14, 2025 08:14 Inactive
@memoyil memoyil force-pushed the feature/fix_bridge_input_paste_non_numeric_in_mobile branch from 85f9998 to 89370e8 Compare January 14, 2025 08:15
@memoyil
Copy link
Collaborator Author

memoyil commented Jan 14, 2025

@SocketSecurity ignore-all

@memoyil memoyil force-pushed the feature/fix_bridge_input_paste_non_numeric_in_mobile branch from 89370e8 to 99dea64 Compare February 17, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant