give priority to '-e/--env-file' option over default files (#5628) #5629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Signed-off-by: Jalaj <[email protected]>
|
The failing test seems to be failing in other actions before this PR as well: https://github.com/pallets/flask/actions/runs/11709066697/job/32612272783 |
|
I don't think this is going to work. The env vars need to be loaded before creating the context, as the processing pipeline needs to be able to see the env vars to use their values for the parameters. |
…ult files In the previous commit, pallets#5628 was fixed by creating the context before loading the default environment variables. However, as pointed out by @davidism, this can cause issues with the load pipeline. Thus, this commit reverses that approach and uses the `override` argument provided by `python-dotenv` to give priority to custom file over default file. Signed-off-by: Jalaj <[email protected]>
|
|
|
I'm also already working on this using a different approach, sorry for the confusion. |
Okay, no worries. Should I close this PR then? |
|
Closing in favor of #5630 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #5628 . The issue arose from the fact that
FlaskGroup().make_context()was loading the default env files before loading the arguments (by callingsuper().make_context(). Simply reversing the order of these actions fixes the issue. I have added the relevant tests to make sure it works.should fail without the change.
.. versionchanged::entries in any relevant code docs.