Minor changes to username_recovery #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1057 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 37 37
Lines 4857 4858 +1
=======================================
+ Hits 4779 4780 +1
Misses 78 78 ☔ View full report in Codecov by Sentry. |
jamesejr
reviewed
Jan 7, 2025
- username recovery is an independent feature - so it can exist w/o the recovery feature. Separate that out when initialiing blueprint - update docs around username, username_recovery
mandervrik
reviewed
Jan 11, 2025
| @@ -478,6 +478,7 @@ welcome_existing SECURITY_SEND_REGISTER_EMAIL SECURITY_EM | |||
| welcome_existing_username SECURITY_SEND_REGISTER_EMAIL SECURITY_EMAIL_SUBJECT_REGISTER - email user_not_registered | |||
| SECURITY_RETURN_GENERIC_RESPONSES - username | |||
| username_recovery SECURITY_USERNAME_RECOVERY SECURITY_EMAIL_SUBJECT_USERNAME_RECOVERY - user username_recovery_email_sent | |||
| - username | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
username recovery is an independent feature - so it can exist w/o the recovery feature. Separate that out when initialiing blueprint
update docs around username, username_recovery
@jamesejr