Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Conversation

@oisinmulvihill
Copy link

Fixed a bug whereby a dict cause AttributeError even though the _default_jwt_payload_handler is supposed to handle objects and dicts. I've added a test and my proposed fix for this.

…ult_jwt_payload_handler is supposed to handle objects and dicts. I've added a test and my proposed fix for this.
@oisinmulvihill
Copy link
Author

all tests pass locally not sure what travis-ci is complaining about :(

@coveralls
Copy link

coveralls commented May 19, 2016

Coverage Status

Coverage decreased (-0.6%) to 95.092% when pulling 351d94a on oisinmulvihill:master into c270841 on mattupstate:master.

@oisinmulvihill
Copy link
Author

$ py.test
============================================================================================ test session starts =============================================================================================
platform linux2 -- Python 2.7.6, pytest-2.9.2, py-1.4.31, pluggy-0.3.1
rootdir: /home/vagrant/src/flask-jwt, inifile: setup.cfg
plugins: flask-0.10.0
collected 20 items

tests/test_jwt.py ....................

========================================================================================= 20 passed in 2.27 seconds ==========================================================================================
(scpenv)
vagrant@devbox [flask-jwt]
$

@oisinmulvihill
Copy link
Author

Weird, when run elsewhere its causing a problem but not for me, makes it hard to fix this :(

@stephane
Copy link

stephane commented Aug 3, 2016

Already fixed by #63 and many others.

@oisinmulvihill
Copy link
Author

great, can join mainline again, thx

@stephane
Copy link

stephane commented Aug 4, 2016

Excepted #63 is not merged yet... (the project seems dead #95)

@oisinmulvihill
Copy link
Author

I'll pull in your fixes from your branch https://github.com/webstack/flask-jwt/tree/fork into mine then in the meantime.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants