Filter pull requests pulled by Bulldozer #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluekeyes
reviewed
Oct 30, 2024
pull/pull_requests.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| if strings.HasPrefix(ref, "refs/heads/") { | ||
| ref = strings.TrimPrefix(ref, "refs/heads/") |
There was a problem hiding this comment.
nit: TrimPrefix returns the unmodified input if it doesn't contain the prefix, so there's usually no need to test with HasPrefix before calling TrimPrefix. If you do care about knowing if the prefix existed or not, you can also use CutPrefix`.
bluekeyes
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have been getting all pull requests in a given repo but the changes proposed here will filter the results to only retrieve the pull requests we care about via SHA or ref.