Skip to content

Conversation

@matthewlee07
Copy link

…. or add >= current version

@sjreich
Copy link

sjreich commented Nov 9, 2018

Hi Matt, let's move towards getting this change actually merged in.

  1. I can't really tell, but if you updated this by running bundle update, can you do so instead with bundle update cucumber? (The principal is to make small updates, rather than big ones.) If you already did the latter, then great.
  2. It looks like there are some things you changed that weren't essential or relevant. Can you drop those changes out? (The principal is to minimize the "churn" in the codebase.)
  3. Can you clean up the documentation around this PR - the name, the introductory comment, so that's obvious to everyone what was going on here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants