Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [WLEO-241] Presentation StartFlow input parameters #184

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

LazyAfternoons
Copy link
Contributor

@LazyAfternoons LazyAfternoons commented Jan 31, 2025

List of Changes

  • Change the StartFlow input parameters which now takes requestUri and clientId instead of the whole URL, giving the consumer app the responsibility to parse the URL;
  • Update tests.

Motivation and Context

This change is needed because the URL is already parsed and validated by the consumer app.

How Has This Been Tested?

Test a presentation flow.

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@LazyAfternoons LazyAfternoons changed the base branch from master to eudiw-master January 31, 2025 11:46
@LazyAfternoons LazyAfternoons marked this pull request as ready for review January 31, 2025 11:48
@LazyAfternoons LazyAfternoons requested a review from a team as a code owner January 31, 2025 11:48
@LazyAfternoons LazyAfternoons added this pull request to the merge queue Jan 31, 2025
Merged via the queue into eudiw-master with commit 8db5947 Jan 31, 2025
6 checks passed
@LazyAfternoons LazyAfternoons deleted the WLEO-241-startflow branch January 31, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants