Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [SIW-1268] Deletion of optional attributes from the credential issuer entity configuration #175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RiccardoMolinari95
Copy link
Collaborator

@RiccardoMolinari95 RiccardoMolinari95 commented Jan 21, 2025

List of Changes

This PR eliminates the attributes that aren't passed from the credential issuer entity configuration after verifying the technical specifications. Specifically, it removes optional attributes that are not specified in the technical rules.
In other cases, the optional attribute has been removed because the attribute is being passed.

Since these attributes are neither passed in the entity configuration nor specified in the technical rules, they can be safely removed.

Motivation and Context

This change is required to ensure that the entity configuration we receive is consistent with the one we subsequently parse

How Has This Been Tested?

You should be able to obtain PID and credentials

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@RiccardoMolinari95 RiccardoMolinari95 requested a review from a team as a code owner January 21, 2025 15:26
@RiccardoMolinari95 RiccardoMolinari95 self-assigned this Jan 21, 2025
@github-actions github-actions bot added the chore label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant