Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IT Wallet): [SIW-1918] Add iPatente CTA in MDL details screen #6577

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Dec 20, 2024

Short description

This PR adds the iPatente service CTA in the MDL details screen

List of changes proposed in this pull request

  • Bumped IO_SERVICES_METADATA_VERSION to version 1.0.52
  • Moved ITW remote config selectors to features/itWallet/common/store/selectors/remoteConfig.ts
  • Added itwIsIPatenteCtaEnabledSelector selector
  • Added iPatente CTA in the MDL details screen

How to test

Navigate to the MDL details screen, check that the iPatente CTA is visible.
Mock the /status/backend response setting itw.ipatente_cta_enabled to false and check that the CTA is not visibile.

Demo

RPReplay_Final1734702140.MP4

@mastro993 mastro993 self-assigned this Dec 20, 2024
@mastro993 mastro993 marked this pull request as ready for review December 20, 2024 14:05
Copy link
Contributor

github-actions bot commented Dec 20, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue SIW-1918

@mastro993 mastro993 changed the title [SIW-1918] Add iPatente CTA in MDL details screen feat(IT Wallet): [SIW-1918] Add iPatente CTA in MDL details screen Dec 20, 2024
@MatteoPaletta
Copy link

@mastro993 Dobbiamo modificare il testo della CTA in "Vai al saldo punti patente".

locales/en/index.yml Outdated Show resolved Hide resolved
locales/it/index.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 49.29%. Comparing base (ecd87bc) to head (55f9d3e).

Files with missing lines Patch % Lines
...es/itwallet/common/store/selectors/remoteConfig.ts 74.28% 8 Missing and 1 partial ⚠️
...tation/components/ItwPresentationDetailsFooter.tsx 75.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6577   +/-   ##
=======================================
  Coverage   49.28%   49.29%           
=======================================
  Files        1558     1559    +1     
  Lines       32156    32173   +17     
  Branches     7325     7280   -45     
=======================================
+ Hits        15849    15860   +11     
- Misses      16258    16275   +17     
+ Partials       49       38   -11     
Files with missing lines Coverage Δ
.../features/itwallet/common/store/selectors/index.ts 85.71% <ø> (ø)
...allet/discovery/screens/ItwDiscoveryInfoScreen.tsx 86.66% <100.00%> (ø)
...n/screens/ItwIdentificationModeSelectionScreen.tsx 79.31% <ø> (ø)
...nce/screens/ItwIssuanceCredentialFailureScreen.tsx 9.25% <ø> (ø)
...tures/itwallet/navigation/useItwLinkingOptions.tsx 100.00% <ø> (ø)
.../onboarding/screens/WalletCardOnboardingScreen.tsx 80.43% <ø> (ø)
.../screens/ItwPresentationCredentialDetailScreen.tsx 10.34% <ø> (ø)
...et/trustmark/components/ItwCredentialTrustmark.tsx 20.96% <ø> (ø)
...eatures/wallet/components/WalletCardsContainer.tsx 100.00% <ø> (ø)
ts/store/reducers/__mock__/backendStatus.ts 100.00% <ø> (ø)
... and 3 more

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd87bc...55f9d3e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants