Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross):[IOAPPX-422] Replace the legacy markdown renderer with IOMarkdown #6445

Draft
wants to merge 60 commits into
base: master
Choose a base branch
from

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Nov 22, 2024

Short description

This PR removes any legacy markdown renderer in favour of IOMarkdown

List of changes proposed in this pull request

  • Remove LegacyMarkdown

Preview

CiePinScreen

Old New
Old New

FciDocumentsScreen

Old New
FciDocumentsScreen_old FciDocumentsScreen_new

EycaInformationComponent

Old New
EycaInformationComponent_old EycaInformationComponent_new

InitiativeDetailsScreen

Old New New
InitiativeDetailsScreen_old InitiativeDetailsScreen_new_0 InitiativeDetailsScreen_new_1

RootedDeviceModal

Old New
RootedDeviceModal_old RootedDeviceModal_new

ShareDataFeatureInfos

Old New
Simulator Screenshot - iPhone 16 Pro - 2024-11-26 at 13 44 06 Simulator Screenshot - iPhone 16 Pro - 2024-11-26 at 13 48 00

ManualConfigBottomSheet

Old New
Simulator Screenshot - iPhone 16 Pro - 2024-11-26 at 13 44 53 Simulator Screenshot - iPhone 16 Pro - 2024-11-26 at 13 48 13

InitiativeRulesInfoBox

Old New
InitiativeRulesInfoBox_old InitiativeRulesInfoBox_new

PDNDPrerequisitesScreen

Old New
PDNDPrerequisitesScreen_old PDNDPrerequisitesScreen_new

MessageDetailsScreen

Old New
M001_old M001_new
M002_old M002_new
M003_old M003_new
M004_old M004_new
M005_old M005_new

ServiceDetailsScreen

Old New
S001_old S001_new

CgnInformationScreen

Old New
CGN001_old CGN001_new
CGN002_old CGN002_new
CGN003_old CGN003_new
CGN004_old CGN004_new

Authors

@Vangaorth @adelloste @dmnplb

How to test

All affected sections have been tested and related screenshots are linked in this PR. Assuming that IOMarkdown is a fully working component, either statically check that the edited code makes sense or, using the io-dev-api-server, verify that every impacted screen/component/bottom-sheet renders properly

@dmnplb dmnplb added enhancement Design System New visual language and reduction of previous UI clutter labels Nov 22, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-422] Replace the legacy markdown renderer with IOMarkdown in the Messages and Services screens chore(Cross): [IOAPPX-422] Replace the legacy markdown renderer with IOMarkdown in the Messages and Services screens Nov 22, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 22, 2024

Affected stories

  • ⚙️ IOAPPX-422: Sostituzione IOMarkdown su messaggi e servizi
    subtask of

Generated by 🚫 dangerJS against 7a5385b

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 68.66667% with 47 lines in your changes missing coverage. Please review.

Project coverage is 50.02%. Comparing base (7667aac) to head (459e760).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
ts/components/IOMarkdown/customRules.tsx 22.22% 14 Missing ⚠️
ts/components/IOMarkdown/markdownRenderer.ts 79.10% 14 Missing ⚠️
ts/components/IOMarkdown/renderRules.tsx 73.33% 8 Missing ⚠️
...ces/details/components/CardWithMarkdownContent.tsx 0.00% 3 Missing ⚠️
...omponents/detail/eyca/EycaInformationComponent.tsx 50.00% 2 Missing ⚠️
...us/common/components/BonusInformationComponent.tsx 0.00% 1 Missing ⚠️
...eatures/messages/saga/handleMessagePrecondition.ts 0.00% 1 Missing ⚠️
ts/screens/profile/DeveloperModeSection.tsx 66.66% 1 Missing ⚠️
...le/components/services/ManualConfigBottomSheet.tsx 66.66% 1 Missing ⚠️
ts/store/reducers/persistedPreferences.ts 75.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6445      +/-   ##
==========================================
+ Coverage   49.85%   50.02%   +0.17%     
==========================================
  Files        1564     1558       -6     
  Lines       32379    32242     -137     
  Branches     7290     7234      -56     
==========================================
- Hits        16141    16130      -11     
+ Misses      16200    16074     -126     
  Partials       38       38              
Files with missing lines Coverage Δ
ts/components/IOMarkdown/index.tsx 100.00% <100.00%> (ø)
ts/components/ui/LoadingSkeleton.tsx 33.33% <ø> (ø)
ts/features/fci/hooks/useFciAbortSignatureFlow.tsx 61.11% <ø> (ø)
...s/fims/singleSignOn/components/FimsPrivacyInfo.tsx 20.00% <ø> (ø)
...s/fims/singleSignOn/components/FimsSuccessBody.tsx 9.09% <ø> (ø)
...dpay/details/components/InitiativeRulesInfoBox.tsx 30.00% <ø> (ø)
...rding/components/OnboardingDescriptionMarkdown.tsx 33.33% <ø> (ø)
...pay/onboarding/screens/PDNDPrerequisitesScreen.tsx 5.26% <ø> (ø)
...let/identification/screens/cie/ItwCiePinScreen.tsx 14.70% <ø> (ø)
.../messages/components/Home/PreconditionsContent.tsx 100.00% <100.00%> (ø)
... and 22 more

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7667aac...459e760. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Design System New visual language and reduction of previous UI clutter enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants