Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-833] Sorting algorithms for PSP bundles #6382

Open
wants to merge 51 commits into
base: master
Choose a base branch
from

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request updating the sorting algorithm for PSP bundles

  • Updated sorting logic in getSortedPspList function:

List of changes proposed in this pull request

  • Updated sorting logic in getSortedPspList function

How to test

  • Tap in Inquadra and try to pay something
  • Select a payment method
  • Check PSP bundles list
  • Tap on Ordina
  • Tap on a radio button to select a sorting option, then verify that the list is sorted correctly according to the chosen algorithm

Preview

Screen.Recording.2024-11-06.at.17.12.02.mov

@pagopa-github-bot pagopa-github-bot changed the title refactor: [IOBP-833] Sorting algorithms for PSP bundles chore: [IOBP-833] Sorting algorithms for PSP bundles Nov 7, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 7, 2024

Affected stories

  • ⚙️ IOBP-833: [Improvement] Adeguamento a nuove logiche di ordinamento GEC
    subtask of
    • IOBP-701: Evolutive flusso di on-boarding/pagamento

Generated by 🚫 dangerJS against e09e78b

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 31.30%. Comparing base (d76c8c9) to head (a05f0a1).

Files with missing lines Patch % Lines
...features/payments/checkout/store/reducers/index.ts 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d76c8c9) and HEAD (a05f0a1). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (d76c8c9) HEAD (a05f0a1)
10 3
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6382       +/-   ##
===========================================
- Coverage   49.59%   31.30%   -18.29%     
===========================================
  Files        1564     1528       -36     
  Lines       32355    31824      -531     
  Branches     7328     7149      -179     
===========================================
- Hits        16045     9964     -6081     
- Misses      16261    21838     +5577     
+ Partials       49       22       -27     
Files with missing lines Coverage Δ
...ents/checkout/components/WalletPspListSkeleton.tsx 100.00% <100.00%> (+66.66%) ⬆️
.../payments/checkout/hooks/useSortPspBottomSheet.tsx 100.00% <100.00%> (+81.81%) ⬆️
...ts/checkout/screens/WalletPaymentPickPspScreen.tsx 89.23% <100.00%> (+86.15%) ⬆️
ts/features/payments/common/utils/index.ts 41.55% <100.00%> (+1.29%) ⬆️
...features/payments/checkout/store/reducers/index.ts 18.98% <0.00%> (-4.77%) ⬇️

... and 506 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76c8c9...a05f0a1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants