Conversation
QSparks
approved these changes
Feb 6, 2026
QSparks
left a comment
There was a problem hiding this comment.
LGTM! Not much to review, just spotted a couple of typos.
Out of scope: I tested the demo and noticed that if you first select a watershed that includes a downstream path, then change to one that does not, the previously highlighted path is not removed from the map.
Collaborator
Author
|
Test notes from @mschnorb :
I think the third one may be a side effect of the BC Albers project we're using, which is only valid within a specific region, and gets weird when you zoom outside that region. Probably not a priority at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly a big data update; code changes are minimal.
Data is now available for a much larger area, including Haida Gwaii, Vancouver Island, and most of the mainland BC Coast.
Please poke at the demo a little and see if you can find anything broken. Haida Gwaii is the only entirely new top-level region, so it's a good place to poke around.
Resolves #81