Script for copying files from one ensemble to another#3
Open
Script for copying files from one ensemble to another#3
Conversation
rod-glover
approved these changes
Jul 5, 2018
rod-glover
left a comment
rod-glover
left a comment
There was a problem hiding this comment.
LGTM, apart from a couple of very minor items.
| try: | ||
| logger.info("Generating list of files associated with ensemble {}".format(args.source)) | ||
| session = Session() | ||
| source_ensemble = find_ensemble(session, args.source, 1) |
There was a problem hiding this comment.
source_ensemble isn't used anywhere. Is it just to verify that the ensemble exists? If so, that may not really be necessary.
| filenames.append(f.filename) | ||
| except: | ||
| logger.error(traceback.format_exc()) | ||
| session.rollback() |
There was a problem hiding this comment.
If you're only doing selects (which you are), rollback isn't necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script was written to copy all files from from one metadata ensemble in the database to another. Seems like it might be useful again someday.