Skip to content

Update workflows#252

Merged
corviday merged 3 commits intomasterfrom
workflows
Jun 20, 2025
Merged

Update workflows#252
corviday merged 3 commits intomasterfrom
workflows

Conversation

@corviday
Copy link
Contributor

@corviday corviday commented Jun 19, 2025

Fixes a couple things missed during the big maintenance PR. The only substantive changes to this PR are the two files in the .github/workflows directory; everything else is just black formatting changes.

  1. Adds a code format check with black on commit
  2. Fixes the broken pypi publishing script, which was still using setup.py

Question about pypi publishing: most of our other repositories with a pypi publish script, like this one, install the package before building it. When I tried to follow that procedure here, I ran into errors installing gdal, so I just removed the poetry install step.

Things seem to be working, the workflow completes, version 3.6.6 is available on our pypi, and I was able to add it to a new python project. Are there any hidden problems with skipping the install step?

Resolves #251

Copy link
Contributor

@QSparks QSparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
For your question about the poetry installation step with GDAL, I believe it could be failing because the Ubuntu 24.04 runner lacks the necessary system libraries for GDAL (gdal-bin and libgdal-dev).

@corviday corviday merged commit 40c0593 into master Jun 20, 2025
6 checks passed
@corviday corviday deleted the workflows branch June 20, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workflow improvements

2 participants