Merged
Conversation
Previous version of numpy didn't conform to PEP517 and failed to install
This gets us a lot more deprecation warnings
No specific purpose... just future-proofing
New versions of SQLAlchemy and Flask-SQLAlchemy don't allow instantiating a flask app and then using it in the tests. "RuntimeError: A 'SQLAlchemy' instance has already been registered on this Flask app. Import and use that instance instead."
Removed Python 3.8 support since a) it's end-of-life and b) it is not supported by new versions of flask and flask-sqlalchemy. Made minor changes to the app setup procedure, so that the app (and the test_app) get configured *before* extensions are initialized.
Contributor
Author
|
End to end climate explorer maintenance updates test:
|
Contributor
Author
|
Demo looks good (the removed and reindexed data is all the pcic12 RP data). Next steps are to review and merge modelmeta and geospatial-python, update this branch, and then review and merge this one. |
Contributor
Author
|
Includes newly released versions of modelmeta and geospatial-python, and is hopefully ready to go. |
rod-glover
approved these changes
Jun 12, 2025
Contributor
rod-glover
left a comment
rod-glover
left a comment
There was a problem hiding this comment.
LGTM! Just one question as noted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task list:
This should not be merged until the changes to modelmeta and geospatial python are merged and new versions released for use.
resolves #245