Conversation
…p and Reservoir.h to introduce two lake layers to lake enthalpy model.
…orrect coefficient [A], constant [B], and Jacobian matrices. Also initialized value for _mixing_depth in CReservoir::BaseConstructor.
…ng procedure from Community Land Model v5. Added advective heat transfer (i.e. initializing Q_up_new and Q_dn_new). Some code clean-up.
…RouteMassinReservoir
…recting error in calculation of Richardson number (replaced von Karman with k*) and adding upper limit on value of kdiff. Also added a function to get the mixing depth of the lake/reservoir. Some formatting changes to the code.
… fetch, Fe, is estimated as the square root of maximum reservoir surface area (varies by reservoir) and the coefficient, a (mix_depth_coef), and exponent, b (mix_depth_expn), are provided as global parameters (MIX_DEPTH_COEF and MIX_DEPTH_EXPN, respectivley).
Lake thermal update
…wo options to estimate kdiff, added tracking of previous vertical flow rate, corrected solution for use of proper previous energy storage in epilimnion and hypolimnion, added estimate of dE and dEs in case numerical algoriyhm fails to converge, modified calaculation of lake energy balances for output.
…oefficient between lake layers, KDIFF_MAX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
What kind of change does this PR introduce?
Other information: