Update test_smooth so only issue 628 problems remain #1291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update 628 branch with latest master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #628 is tested by test_dnd_class/test_smooth::test_smooth_resolution_shape_arg.
It is currently skipped because of that issue. If the skip is removed then there is an earlier failure because dnd construction with a d2d constructor no longer works. It has to be replaced with read_dnd.
This PR replaces the d2d call with a read_dnd call so that the test is ready to be redeployed when 628 is fixed. The skip has been restored meanwhile. With this fix, the expected failure from 628 occurs.