Voters are incoming #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migration and separation should be ok Voter too Still need to complete the EventSubscriber
quentinus95
requested changes
Aug 3, 2017
src/AppBundle/Entity/Profile.php
Outdated
| use Symfony\Component\Validator\Constraints as Assert; | ||
|
|
||
| /** | ||
| * User's account. |
| $profile = $event->getControllerResult(); | ||
| $method = $event->getRequest()->getMethod(); | ||
|
|
||
| if (!$profile instanceof Profile || Request::METHOD_POST !== $method) { |
There was a problem hiding this comment.
why is access only checked for POST requests ?
| { | ||
| $user = $token->getUser(); | ||
|
|
||
| if (!$user instanceof Profile) { |
There was a problem hiding this comment.
Maybe we should rename profile to UserProfile to get things easier to understand.
| return $this->canAccess($profile, $user); | ||
| } | ||
|
|
||
| throw new \LogicException('This code should not be reached!'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration and separation should be ok
Voter too
Still need to complete the EventSubscriber