Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom fonts #110

Closed
wants to merge 3 commits into from
Closed

Conversation

gtrafford
Copy link

I added support for custom fonts. I created an issue about this (#109) but there has been no reply.

@VisualMelon
Copy link

Sorry you've not had any response. I don't know if there is anyone in the team at the moment who is able to test the Xamarain components apart from Xamarin.Forms.

The azure devops build doesn't seem to touch the android stuff; the appyevor failure seems to be a version mismatch (pretty sure the code compiled fine). Could you stuff the lookup logic into its own method?

I'm rather busy at the moment (and have a long list of OxyPlot things I need to get done as well), but I'll see if I can borrow some devices with which to test.

@janusw
Copy link
Member

janusw commented Dec 5, 2022

Very late review: It seems you're only touching the Android implementation, so presumably your solution will only work on Android?

In general it's a nice idea to support custom fonts, but we should make sure that it works on all platforms (most importantly Android and iOS, but also Mac and UWP).

@gtrafford gtrafford closed this Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants