-
-
Notifications
You must be signed in to change notification settings - Fork 261
Enable Checkmake #5802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Checkmake #5802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables the Checkmake linter for Makefile analysis by removing the disabled status that was previously set due to security concerns.
Key Changes:
- Removes the
disabled: true
configuration for the MAKEFILE_CHECKMAKE linter - Removes the associated
disabled_reason
referencing security issues from GitHub issue #99
@@ -33,8 +33,6 @@ linters: | |||
- **Configuration file support** via `.checkmake.ini` for project-specific rules | |||
- **Detailed error reporting** with line numbers and suggestions | |||
- **Build optimization suggestions** improving compilation efficiency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabling Checkmake after it was disabled for security reasons requires verification that the referenced security issue (checkmake/checkmake#99) has been resolved. Consider adding a comment documenting that the security concern has been addressed or include validation steps in the PR description.
Copilot uses AI. Check for mistakes.
/build
|
|
🦙 MegaLinter status:
|
/build
|
|
Fixes #
Proposed Changes
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance