Skip to content

Create PRs for RFDs in the ideation state #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create PRs for RFDs in the ideation state #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rfd-processor/src/updater/create_pull_request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ impl RfdUpdateAction for CreatePullRequest {
..
} = ctx;

// We only ever create pull requests if the RFD is in the discussion state, we are not
// We only ever create pull requests if the RFD is in the discussion or ideation state, we are not
// handling an update on the default branch, and there are no previous pull requests for
// for this branch. This includes Closed pull requests, therefore this action will not
// re-open or create a new pull request for a branch that previously had an open PR
if update.location.branch != update.location.default_branch
&& new.is_state("discussion")
&& (new.is_state("discussion") || new.is_state("ideation"))
&& pull_requests.is_empty()
{
tracing::info!("RFD is in the discussion state but there are no open pull requests, creating a new pull request");
Expand Down
Loading